Skip to content

Fix native Windows startup, shell execution and view consoles - #21

Closed
edward1987 wants to merge 1 commit into
pullboard-dev:mainfrom
edward1987:fix/windows-native-compat
Closed

edward1987 wants to merge 1 commit into
pullboard-dev:mainfrom
edward1987:fix/windows-native-compat

Conversation

@edward1987

Copy link
Copy Markdown

What changed?

Native Windows could reject private relay storage because Node reports synthetic Unix mode bits, execute POSIX gate/formatter syntax through cmd.exe, and flash console windows on every background-view refresh.

  • Validate NTFS ownership/DACLs and private parent directories before credential writes, retaining existing fail-closed checks.
  • Use Git for Windows Bash for POSIX command strings and hide console child windows while preserving native launch guards, callbacks, errors and promisification.
  • Preserve process provenance in source maps and browser admission, with Windows and cross-platform regressions.

No new dependencies.

Linked issue

No linked issue; reproduced on native Windows with Pullboard 0.9.3.

Which approved spec rows does this serve?

A8 (cross-platform gate aim). This is a partial portability repair: timed shells, process-group cleanup and the complete Windows gate remain follow-up work.

How was it proven?

  • Native Windows: node --test test/windows-storage.test.js test/windows-processes.test.js — 15 passed, 0 skipped.
  • Full Linux gate not completed for this draft; the contributor requested publishing the Windows fixes without waiting for it. No Linux gate pass is claimed.
  • Independent static review covered NTFS handling, guard bindings and source-analysis integration.
  • Original Windows bootstrap/Git regressions failed before the compatibility fixes; no existing test was removed or weakened.

Contribution checks

  • DCO sign-off by the contributor.
  • Contributor personally completes the CLA if required.

Kept as draft for maintainer review. No legal acknowledgment was made automatically.

@edward1987
edward1987 marked this pull request as ready for review November 5, 2026 17:07
@coreyolson

coreyolson commented Nov 6, 2026 •

Copy link
Copy Markdown
Collaborator

Thank you. About to ship 0.9.4, a large rewrite that moves everything under src/ into packages/* and apps/*. It was a necessary step for speed, cost and maintainability: this version untangles the codebase, and it sets out how the system grows from here. It also serves as an example for how an existing codebase might migrate legacy code.

Once 0.9.4 ships, we will formalize the contribution process; then we can accept code from outside contributors. Briefly, it's a CLA you agree to with one comment on your pull request. It credits you as the author while keeping Pullboard clean; see CONTRIBUTING.md.

A quick check against 0.9.4: all three Windows problems are still present.

Once 0.9.4 ships, we'll see where this all stands, for 0.9.5 inclusion.

Hang tight, appreciate your patience.

@coreyolson coreyolson added the pending Waiting on the next release; we'll come back to it once it ships label Nov 6, 2026
@coreyolson

Copy link
Copy Markdown
Collaborator

This no longer applies: the files it changes moved in the 0.9.4 cell restructure. We're setting up our own Windows machine to verify native Windows. No need to resubmit. Closing. Thanks.

@coreyolson coreyolson closed this Nov 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pending Waiting on the next release; we'll come back to it once it ships

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants